Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper function for onCreate appearing unexpectedly in room's On Create IDE #279

Closed
oaklandgit opened this issue Apr 11, 2021 · 4 comments
Labels
help wanted Extra attention is needed scope:ide This involves changes to ct.IDE, its UI and logic state:stale This aged well. Probably not relevant now. type:bug Something isn't working

Comments

@oaklandgit
Copy link

Describe the bug
See this screenshot. Notice how the onCreate function is appearing in the IDE. Also notice the repeated line number 1.
The problem fixed itself after restarting ctjs.

Screen Shot 2021-04-11 at 1 52 36 PM

To Reproduce
Unfortunately, I'm not sure how to reproduce this.

System information report
Ct.js v1.7.0 😽 (packaged)

NW.JS v0.51.2
Chromium v88.0.4324.182
Node.js v15.8.0
Pixi.js v5.1.2

WebGL available
WebGL vendor Intel Inc.
WebGL renderer Intel(R) Iris(TM) Plus Graphics OpenGL Engine
OS darwin x64 // Darwin 20.3.0

@oaklandgit oaklandgit added the type:bug Something isn't working label Apr 11, 2021
@oaklandgit oaklandgit changed the title Wrapper function for onCreate appearing unexpectedly in room's onCreate IDE Wrapper function for onCreate appearing unexpectedly in room's On Create IDE Apr 11, 2021
@oaklandgit
Copy link
Author

Can happen with any tab. (e.g. On Draw).

@CosmoMyzrailGorynych CosmoMyzrailGorynych added the help wanted Extra attention is needed label Apr 11, 2021
@CosmoMyzrailGorynych
Copy link
Collaborator

This is the result of my workarounds for monaco's issue microsoft/monaco-editor#45

The problem fixed itself after restarting ctjs.

Can be fixed by closing and reopening type editor / room events editor.

Unfortunately, I'm not sure how to reproduce this.

One of the ways to get a variation of this bug:

  1. Open a code editor of a type or a room
  2. Write anything on the first line
  3. Alt+Up arrow
  4. The line disappears
  5. Reopen the asset editor
  6. You can now see a wrapping function. (Another one gets created and is invisible so removing the one inside your code will fix the issue)

@CosmoMyzrailGorynych CosmoMyzrailGorynych added this to Worth its attention in Main dev board Mar 27, 2022
@CosmoMyzrailGorynych CosmoMyzrailGorynych added the scope:ide This involves changes to ct.IDE, its UI and logic label Mar 27, 2022
@stale
Copy link

stale bot commented Jul 30, 2022

Hey there 👋 I marked this issue as stale as it hadn't brought much attention for quite a while.
I do understand that stale issues are still issues, yet here stale issues receive the least attention from maintainers so they can focus on more relevant tasks. You can help with this issue by checking whether it affects latest versions of ct.js and writing about it if it does, providing an example project and steps to reproduce. Or maybe you can close it with a PR!
Note that some platform-dependent issues can't be resolved by developers due to the absense of such devices :c We will need help from you for such tasks.
If this issue won't get attention in three months, it will be closed.

@stale stale bot added the state:stale This aged well. Probably not relevant now. label Jul 30, 2022
@stale
Copy link

stale bot commented Oct 28, 2022

This issue is now closed! Please create a new one with a proper template if this issue still affects ct.js.

@stale stale bot closed this as completed Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed scope:ide This involves changes to ct.IDE, its UI and logic state:stale This aged well. Probably not relevant now. type:bug Something isn't working
Projects
Status: Done
Main dev board
  
Worth its attention
Development

No branches or pull requests

2 participants