New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove postcss-svgo from the default preset #992
Comments
Yep, I agree, sometimes I think we need to switch on https://github.com/cssnano/cssnano/tree/master/packages/cssnano-preset-lite by default, it is faster and it is safe (only spaces, comments and empty rules) |
I get a lot of value out of having a broader set of defaults that encompasses everything that's believed to do safe optimizations independent of semantics, but as long as that's also available as a preset I'd be happy. |
I am happy to tell you that svgo has found a new maintainer(@TrySound ), and we have re-established security as the core idea, and look forward to working with the PostCSS community. It would be better if @ben-eb had time to re-maintain postcss-svgo. Ben-eb is also an excellent open source contributor to the PostCSS community. |
If things are so bad with the previous SVGO version, we could update to SVGO 2 for the 5.0.0 release. @anikethsaha @alexander-akait any thoughts? |
Yea I think we should include the SVGO v2 as even if there are breaking changes, it wont be an issue. 👍 |
@anikethsaha Yes, PR welcome |
PR to update SVGO to newly maintained version 2: #1016 SVG experts are welcome to suggest improvements. |
Closing this since SVGO is maintained again. We could open an issue for changing the default preset to lite though (as #992 (comment) suggests). |
The svgo package which postcss-svgo uses has a large number of outstanding bugs, a number of which I've personally seen result in changes to the rendering of SVGs embedded in CSS files. In addition, the project seems to have been abandoned, with 59 open pull requests and no commits since December 2019. In light of this, I believe it is no longer on track to meet the default preset's goal of never changing input CSS in a way that could cause rendering differences, and as such it should no longer be enabled by default.
The text was updated successfully, but these errors were encountered: