New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve case of css custom variables. Fixes #648 #649
Preserve case of css custom variables. Fixes #648 #649
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! Maybe we need check other places in postcss-merge-longhand
on same problem. Can you be champion this?
What happened to the diff? |
@evilebottnawi Thanks! Well, sure, but I'm not sure when I will be able to find time to do it! Will put it on my TODO list! @andyjansson sorry, VS Code must have "helped out" with whitespaces. EDIT: Apparently line breaks are CRLF à la Windows in the original file. On my Mac the default is just LF so VS Code changed all line breaks... |
AFAICT there was only one place which lowercased strings, and that was taken care of by the initial commit. However, I added some more tests to ensure this. |
/cc @andyjansson |
It's fine. In the long run, I'd probably prefer distinct formatting functions for widths, styles, and colors so we can handle any potential edge cases. |
When do you expect to make the merge? Will there also be a new minor release after that? (would be great) |
@p-a Today |
Fix matches var(--somename) and preserve case of the variable name.
Fixes #648