fix: do not merge properties with unset #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
approved these changes
Oct 12, 2018
|
@jordrake Looks we need one-two additional tests to increase coverage |
jordrake
force-pushed
the
merge-unset
branch
2 times, most recently
from
14111bb
to
d6839f6
Compare
andyjansson
approved these changes
Oct 12, 2018
|
Just looking into the coverage right now, seems that some of those return falses are never getting hit which is curious! |
|
@jordrake let's solve this in next refactor 👍 |
|
Thanks for work! |
|
I figured out what it is. The test case only reach canMerge if they contain all of the properties (TRBL) of the box. jordrake@51f26ac corrects it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered this issue whilst using cssnano (great tool by the way, thank you very much!) and believe it falls into the same category as initial and inherit (where it impacts the entire property).
I wasn't sure if I need to create an issue first but if I do please let me know.
I realise that this is growing in complexity and could be done with a more generic solution (similar to the reserved keyword arrays I see in other packages within this repo) so I am happy to convert this file to that approach if you like. Similarly, I could also add 'none' to not be merged too.