Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update browserslist and autoprefixer #1444

Merged
merged 3 commits into from Oct 26, 2022
Merged

chore: update browserslist and autoprefixer #1444

merged 3 commits into from Oct 26, 2022

Conversation

ludofischer
Copy link
Collaborator

@ludofischer ludofischer commented Oct 26, 2022 •
edited 

git diff --diff-algorithm=minimal --word-diff=color HEAD^

gives a good overview of the changes. Changes include removing the -moz-test-decoration, removing -webkit-keyframes.

@ludofischer ludofischer marked this pull request as draft October 26, 2022 06:51
@ludofischer
Copy link
Collaborator Author

Converting to draft because there are other unexpected test failures besides the fixtures.

@ludofischer
chore: update browserslist, autoprefixer and css-declaration-sorter
9372358 
Add to destroy and recreate pnpm-lock.yaml and node_modules,
else the tests hang
@ludofischer
test: fix failures caused by browserslists moving IE11 to dead
fe157b6 
Add default browserslist environment containing IE11.
Dropped some -moz and -webkit prefixes since I could not manage
to create a working browserslist config with old enough browsers
@ludofischer
test: update framework fixtures
edf6640
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022 •
edited

Codecov Report

Base: 97.61% // Head: 97.61% // No change to project coverage 👍

Coverage data is based on head (edf6640) compared to base (d0e3654).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1444   +/-   ##
=======================================
  Coverage   97.61%   97.61%           
=======================================
  Files         122      122           
  Lines        9999     9999           
=======================================
  Hits         9761     9761           
  Misses        238      238

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ludofischer
Copy link
Collaborator Author

The issue was that tests failed because they relied on IE 11 being part of the default browserslist query, and browserslist moved IE11 to 'dead' in a release 4.21. Also some -moz and -webkit prefix disappeared, but I did not try too hard to bring them back (I tried a few configurations but they seemed to result in an empty list of browsers).

@ludofischer ludofischer marked this pull request as ready for review October 26, 2022 18:47
ludofischer
ludofischer commented Oct 26, 2022
View reviewed changes
package.json
@@ -60,6 +61,9 @@
"ie9": [
"IE 9"
],
"ie11": [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test was using this environment, but it was not defined.

@ludofischer ludofischer merged commit 336304b into master Oct 26, 2022
@ludofischer ludofischer deleted the update-browserslist branch October 26, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ludofischer @codecov-commenter @alexander-akait