Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(postcss-reduce-initial): fix build command #1170

Merged
merged 1 commit into from Jul 20, 2021
Merged

chore(postcss-reduce-initial): fix build command #1170

merged 1 commit into from Jul 20, 2021

Conversation

sigveio
Copy link
Collaborator

@sigveio sigveio commented Jul 20, 2021

This pull request aims to fix an outdated babel --ignore for the postcss-reduce-initial acquire script

It was overlooked in #1169

- Fix outdated babel --ignore for the acquire script
@sigveio sigveio requested a review from ludofischer July 20, 2021 16:53
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2021

Codecov Report

Merging #1170 (ae84471) into master (ca5246d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1170   +/-   ##
=======================================
  Coverage   96.55%   96.55%           
=======================================
  Files         116      116           
  Lines        3627     3627           
  Branches     1065     1065           
=======================================
  Hits         3502     3502           
  Misses        117      117           
  Partials        8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca5246d...ae84471. Read the comment docs.

@sigveio
Copy link
Collaborator Author

sigveio commented Jul 20, 2021

Does the project have any rules/guidelines/common practises when it comes to merging into master - beyond having approval of at least one other with write access? E.g. being handled by certain individuals, not merging own PRs, or that kind of things?

And is there anything in particular you pay attention to? From what I've gathered you always squash multiple commits?

Thought I'd ask before doing, and also in the interest of documenting it at some point =)

@ludofischer
Copy link
Collaborator

Does the project have any rules/guidelines/common practises when it comes to merging into master - beyond having approval of at least one other with write access? E.g. being handled by certain individuals, not merging own PRs, or that kind of things?

I don't think there are any special guidelines, as long as somebody else reviews your PRs. @alexander-akait has most permissions on this project. As you can see from the commit history, the people who started the project and contributed most of the code doing the actual transformations have mostly stopped contributing a few years ago, since then there haven't been many committers at all, so I think there never was a need to establish precise guidelines.

@ludofischer ludofischer merged commit b1e9581 into cssnano:master Jul 20, 2021
@ludofischer
Copy link
Collaborator

I generally don't merge PRs immediately after approving them to let others have a chance of looking at them.

@sigveio sigveio deleted the fix-reduce-initial-build branch July 21, 2021 06:23
@sigveio
Copy link
Collaborator Author

sigveio commented Jul 21, 2021

I generally don't merge PRs immediately after approving them to let others have a chance of looking at them.

Good to know - thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants