Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(git): clean up .gitignore files #1156

Merged
merged 2 commits into from Jul 8, 2021
Merged

chore(git): clean up .gitignore files #1156

merged 2 commits into from Jul 8, 2021

Conversation

sigveio
Copy link
Collaborator

@sigveio sigveio commented Jul 3, 2021

Description

This pull request aims to re-organise the projects .gitignore to help keep it clean, and to add various common editor generated folders/files to the list. It also removes some redundant lines from the site/docusaurus .gitignore, which are covered by the root.

The pattern *.bundle.js is also deleted.
(From what I could gather this was added ~5 years ago for a compiler that is now deprecated and no longer used)

Motivation / Context

I generated a .vscode/launch.json file for the vscode debugger while working on a PR, and thought it would be practical for developers to avoid having to stash or delete these types of files between commits. So I wanted to suggest adding common ignores for the most popular IDEs. Which seemed like a good opportunity for some housekeeping =)

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2021

Codecov Report

Merging #1156 (ba5f721) into master (095f901) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1156   +/-   ##
=======================================
  Coverage   96.53%   96.53%           
=======================================
  Files         114      114           
  Lines        3582     3582           
  Branches     1052     1052           
=======================================
  Hits         3458     3458           
  Misses        115      115           
  Partials        9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 095f901...ba5f721. Read the comment docs.

Copy link
Collaborator

@ludofischer ludofischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you gather the list from somewhere or is it based on your own usage only?

.gitignore Show resolved Hide resolved
.gitignore Show resolved Hide resolved
@sigveio
Copy link
Collaborator Author

sigveio commented Jul 3, 2021

Did you gather the list from somewhere or is it based on your own usage only?

I boiled it together from a combination of my own standard .gitignore / dotfiles and the existing ones in this project. I can't recall where I originally gathered these code editor related extensions from - some are from own usage, and some probably inspired from other .gitignores I have come across.

@ludofischer ludofischer merged commit 9886775 into cssnano:master Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants