Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dev): replace del-cli with rimraf #1143

Merged
merged 1 commit into from Jun 7, 2021
Merged

Conversation

ludofischer
Copy link
Collaborator

@ludofischer ludofischer commented Jun 5, 2021

  • replace del-cli with rimraf in package scripts
    to reduce dependencies and speed up build

According to packagephobia del-cli and dependencies weight 2.37MB
del already depends on rimraf, and adds a Promise API but
we do not use it programmatically so we don't need it.

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2021

Codecov Report

Merging #1143 (3c3cf32) into master (b60f54b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1143   +/-   ##
=======================================
  Coverage   96.43%   96.43%           
=======================================
  Files         116      116           
  Lines        3593     3593           
  Branches     1054     1054           
=======================================
  Hits         3465     3465           
  Misses        119      119           
  Partials        9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b60f54b...3c3cf32. Read the comment docs.

* replace del-cli with rimraf in package scripts
to reduce dependencies and speed up build

According to packagephobia del-cli and dependencies weight 2.37MB
del already depends on rimraf, and adds a Promise API but
we do not use it programmatically so we don't need it.
@ludofischer ludofischer merged commit f23108e into master Jun 7, 2021
@ludofischer ludofischer deleted the replace-del-cli branch June 7, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants