Publish cssnano 5.0.4 #1124
Merged
Publish cssnano 5.0.4 #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* postcss-colormin 5.1.1 * cssnano-preset-default 5.1.1 * cssnano-preset-advanced 5.1.1
Maybe we can write own simple script for releasing |
alexander-akait
previously approved these changes
May 21, 2021
|
I published, updating and testing locally it seems to handle numbers normally again. This PR needs re-approval because I have updated the changelog on the website.
The main annoyance for me is updating versions across different packages correctly. For example, if I bump colormin, I need to bump update the dependency and bump cssnano, cssnano-preset-default and cssnano-preset-advanced but not cssnano-preset-lite. We could hard code the dependency graph, otherwise if we start building it by parsing |
alexander-akait
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check carefully that the version numbers match.
This time I generated the changelog by hand as lerna keeps repeating the same changelog entries over and over again and I cannot understand why it bumbs version numbers for packages where nothing changes. We need to find some other solution as lerna is somewhat unmaintained.