New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: issue#1112 #1116
fix: issue#1112 #1116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add test case(s)?
I have added my test case. My test: h1{color:#001;color:#002;color:#003}h2{color:#001;color:#002} before: h1{color:#002;color:#003}h1,h2{color:#001}h2{color:#002} after h1{color:#001;color:#002;color:#003}h2{color:#001;color:#002} |
What should i do next @alexander-akait |
/cc @ludofischer can you look at this? |
Codecov Report
@@ Coverage Diff @@
## master #1116 +/- ##
=======================================
Coverage 96.36% 96.36%
=======================================
Files 115 115
Lines 3575 3576 +1
Branches 1051 1051
=======================================
+ Hits 3445 3446 +1
Misses 121 121
Partials 9 9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I have never touched this part of the code, I think this is a legitimate fix for a legitimate bug. There are also no changes to the integration test results, so I believe we can safely merge this.
@codeonquer Thank you for your PR! |
I am glad to contribute to this project! Thank you all @alexander-akait @ludofischer |
fix #1112
My idea is: