Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(postcss-merge-rules): add some missing known pseudo classes. #1099

Merged
merged 1 commit into from May 12, 2021

Conversation

ludofischer
Copy link
Collaborator

This is a follow-up to #1072 to re-enable merging of :visited links. I have also added non-experimental missing pseudos from #883 to the list, but merging those does not work yet (maybe the default browserslist target is just too strict?)
I have also not added pseudo classes that have to do with web components (:defined) to the list, simply because I am not sure how merging should work for custom components.

* Bring back merging of :visited rules https://caniuse.com/css-sel2
* add form validation pseudo-classes https://caniuse.com/form-validation
* add :any link pseudo-class https://caniuse.com/css-any-link
* add :is pseudo-class https://caniuse.com/css-matches-pseudo
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2021

Codecov Report

Merging #1099 (6c5bc04) into master (c5e0a5e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1099   +/-   ##
=======================================
  Coverage   96.38%   96.38%           
=======================================
  Files         115      115           
  Lines        3594     3595    +1     
  Branches     1060     1060           
=======================================
+ Hits         3464     3465    +1     
  Misses        121      121           
  Partials        9        9           
Impacted Files Coverage Δ
...postcss-merge-rules/src/lib/ensureCompatibility.js 98.64% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5e0a5e...6c5bc04. Read the comment docs.

@ludofischer ludofischer merged commit 4d7fe36 into master May 12, 2021
@ludofischer ludofischer deleted the add-missing-pseudos branch May 12, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants