fix(postcss-merge-rules): prevent breaking rule merges #1072
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two related issues.
First commit, fixes: #730 by not merging the
:host
selector with others.I have rebased #731 as it seems to me it fixes a legitimate problem (angular/angular-cli#18672).
Although this comment #876 (comment) says the PR is already done, the test fails on master.
There's a comment #730 (comment) mentioning the fix is not safe if the browser does not support
:host
but it seems the current situation is what would caus the bug.As #999 states, merging unknown and known selectors causes the browser to ignore the whole rule, so not merging should be the safe path.
Second commit fixes #999. If the pseudo-selector is unknown and does not start with a vendor prefix, do not merge.