chore: update css-declaration-sorter to v6.0.3

[Siilwyn]

Update so Node.js 10 is supported in combination with PostCSS 8.
#1065 (comment)

[Siilwyn]

Seems like some prefixed properties like -webkit-text-size-adjust and other properties like text-rendering shifted around. 🤔

[codecov-commenter]

Codecov Report

Merging #1071 (c83de2a) into master (02e3aab) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1071   +/-   ##
=======================================
  Coverage   96.37%   96.37%           
=======================================
  Files         115      115           
  Lines        3589     3589           
  Branches     1059     1059           
=======================================
  Hits         3459     3459           
  Misses        121      121           
  Partials        9        9           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02e3aab...c83de2a. Read the comment docs.

[ludofischer]

Seems like some prefixed properties like -webkit-text-size-adjust and other properties like text-rendering shifted around. thinking

I think it would be a good idea to add some tests to https://github.com/cssnano/cssnano/blob/master/packages/cssnano-preset-default/src/__tests__/css-declaration-sorter.js, for example to check that integrating the new css-declaration-sorter release fixes #1054

[alexander-akait]

Agree 👍

[alexander-akait]

Can we add test for all?

[Siilwyn]

Rebased and added four tests, one test has weird output not sure what to do with it, maybe something to put into knownIssues.js?

    Expected: "a{border-top:1px solid;border-color:purple}"
    Received: "a{border-color:currentcolor purple purple;border-top:1px solid purple}"

[alexander-akait]

Yep, weird output, maybe problem due order of plugin?

[Siilwyn]

@alexander-akait I did try removing css-declaration-sorter but the test fails with the same output, maybe it's a bug in the merge-longhand logic?

Also the framework integration tests keep failing now, even though I did run yarn build:integration.

[alexander-akait]

@alexander-akait I did try removing css-declaration-sorter but the test fails with the same output, maybe it's a bug in the merge-longhand logic?

let's skip it and open an issue for this 👍

[Siilwyn]

@alexander-akait alright, it's odd though if I run the same input in the cssnano playground it doesn't have this behaviour.

[alexander-akait]

Need fix CI

[ludofischer]

Need fix CI

Probably need to regenerate the integration tests

yarn build:integration

[Siilwyn]

Need fix CI

Probably need to regenerate the integration tests

yarn build:integration

Yes as I said before:

Also the framework integration tests keep failing now, even though I did run yarn build:integration.

So even after running this command there are no changes, any help appreciated.

[alexander-akait]

/cc @ludofischer Can you look? Maybe we have problems with tests...

[Siilwyn]

I rebased, and ran yarn build:integration just to be sure.

[ludofischer]

I rebased, and ran yarn build:integration just to be sure.

But did you commit the modified CSS fixtures? They're in packages/cssnano-preset-default/src/__tests__/integrations/ and packages/cssnano-preset-advanced/src/__tests__/integrations/. I still see the integration tests failing on CI.

[Siilwyn]

I rebased, and ran yarn build:integration just to be sure.

But did you commit the modified CSS fixtures? They're in packages/cssnano-preset-default/src/__tests__/integrations/ and packages/cssnano-preset-advanced/src/__tests__/integrations/. I still see the integration tests failing on CI.

The CSS fixtures stay the same, so nothing to commit. Just to be 200% sure I removed all files in the directories you mention manually before running the build:integration script.

[ludofischer]

The CSS fixtures stay the same, so nothing to commit. Just to be 200% sure I removed all files in the directories you mention manually before running the build:integration script.

Do the tests pass locally? Because in the test logs the result does not match the fixture.

[ludofischer]

I've opened #1071 to add a commit with the fixtures fixed. What I think happened is that the tests testthe code in package/src but the fixtures are generated with the code in dist so you need to run yarn to rebuild all packages before running build:integration.

[Siilwyn]

Alright let me know where to 'continue' this PR, I've cherry picked 4ec0f00. Can also close this one. Thanks for the help!