fix(postcss-merge-longhand): mergeLonghand should not apply to CSS variables #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
approved these changes
Apr 26, 2021
Codecov Report
@@ Coverage Diff @@
## master #1057 +/- ##
==========================================
+ Coverage 97.54% 97.57% +0.02%
==========================================
Files 116 116
Lines 3583 3583
Branches 1059 1058 -1
==========================================
+ Hits 3495 3496 +1
+ Misses 81 80 -1
Partials 7 7
Continue to review full report at Codecov.
|
|
@alexander-akait thanks a lot for the super fast review process! |
KKoukiou
added a commit
to cockpit-project/cockpit
that referenced
this pull request
Jun 7, 2021
Disable mergeLongHand in cssnano. The official fix has already landed upstream [1] but we unfortunately can't update cssnano without updating also CssMinimizerPlugin. An update of CssMinimizerPlugin will not work without webpack-5. Therefore let's keep the WA for now. [1] cssnano/cssnano#1057
KKoukiou
added a commit
to KKoukiou/starter-kit
that referenced
this pull request
Jun 8, 2021
The previously pulled version did not contain cssnano/cssnano#1057
KKoukiou
added a commit
to KKoukiou/starter-kit
that referenced
this pull request
Jun 8, 2021
The previously pulled version did not contain cssnano/cssnano#1057
KKoukiou
added a commit
to cockpit-project/cockpit-certificates
that referenced
this pull request
Jun 9, 2021
The previously pulled version did not contain cssnano/cssnano#1057
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1051