fix(postcss-svgo): fix processing declaration mixing svg and non svg #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close #1040 Skip non-svg data urls even in the case the same declaration also contains svg. Previously the code assumed declaration only contained one uri.
alexander-akait
approved these changes
Apr 8, 2021
ludofischer
commented
Apr 8, 2021
| @@ -198,6 +198,15 @@ test('should warn on SVG containing unclosed tags', async () => { | |||
| expect(result.messages[0].type).toBe('warning'); | |||
| }); | |||
|
|
|||
| test('should only warn with svg data uri', async () => { | |||
| const css = `@font-face { | |||
| src: url("https://example/dfds.woff2") format("woff2"), | |||
There was a problem hiding this comment.
Something weird here. The test fails with an error inside postcss-value-parser if I try a relative URL (url(example/dfds.woff2)). I assume url() handling has been tested elsewhere?
ludofischer
commented
Apr 8, 2021
| @@ -28,6 +28,9 @@ function minify(decl, opts, postcssResult) { | |||
| svg = Buffer.from(base64String, 'base64').toString('utf8'); | |||
| isBase64 = true; | |||
| } else { | |||
| if (!dataURI.test(value)) { | |||
There was a problem hiding this comment.
If the value is not Base64-encoded, the code did not check whether the value was an SVG.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1040
Skip non-svg data urls even in the case the same declaration
also contains svg. Previously the code assumed declaration only
contained one uri.