From 6545a96b7b2ef917a643b859c02781c04c9b57af Mon Sep 17 00:00:00 2001 From: Andy Jansson Date: Thu, 18 Oct 2018 19:05:11 +0200 Subject: [PATCH] Should not throw error when a border property value is undefined (#639) --- packages/postcss-merge-longhand/src/__tests__/borders.js | 7 +++++++ packages/postcss-merge-longhand/src/lib/decl/borders.js | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/packages/postcss-merge-longhand/src/__tests__/borders.js b/packages/postcss-merge-longhand/src/__tests__/borders.js index 2dfb8c803..d754f4206 100644 --- a/packages/postcss-merge-longhand/src/__tests__/borders.js +++ b/packages/postcss-merge-longhand/src/__tests__/borders.js @@ -533,3 +533,10 @@ test( passthroughCSS, 'h1{border-color:red green blue magenta;border-top-color:var(--color-var)}', ); + +test( + 'Should not throw error when a border property value is undefined (#639)', + processCSS, + 'h1{border:2px solid #fff;border-color:inherit}', + 'h1{border:2px solid;border-color:inherit}', +); diff --git a/packages/postcss-merge-longhand/src/lib/decl/borders.js b/packages/postcss-merge-longhand/src/lib/decl/borders.js index 8b99226f0..1c3be2628 100644 --- a/packages/postcss-merge-longhand/src/lib/decl/borders.js +++ b/packages/postcss-merge-longhand/src/lib/decl/borders.js @@ -50,7 +50,7 @@ function getLevel (prop) { } } -const isValueCustomProp = value => !!~value.search(/var\s*\(\s*--/i); +const isValueCustomProp = value => value && !!~value.search(/var\s*\(\s*--/i); function canMergeValues (values) { return !values.some(isValueCustomProp) || values.every(isValueCustomProp);