Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hashPrefix option #98

Merged
merged 2 commits into from Sep 18, 2019
Merged

Add hashPrefix option #98

merged 2 commits into from Sep 18, 2019

Conversation

jessethomson
Copy link
Contributor

@jessethomson jessethomson commented Sep 13, 2019

Background

The webpack css-loader has support for a hashPrefix option to "allow to add custom hash to generate more unique classes".

In postcss-modules, we use the generic-names package, which already supports hashPrefix.

Change

This change simply adds a new hashPrefix option to postcss-modules, which is forwarded to the generic-names generator.

This change is backwards compatible feature and should go out in a minor release.

@jessethomson
Copy link
Contributor Author

I'm not sure why, but two tests unrelated to this change fail in Node 6 and 7 because autoprefixer is adding an unexpected webkit value

Screen Shot 2019-09-13 at 11 02 07 AM

Screen Shot 2019-09-13 at 11 01 59 AM

@madyankin
Copy link
Owner

@jessethomson Thanks a lot for the contribution, I really appreciate it! I'll take a look at this a bit later (in one or two days)

@madyankin madyankin merged commit 6f4d8ee into madyankin:master Sep 18, 2019
@jessethomson
Copy link
Contributor Author

jessethomson commented Sep 19, 2019

Awesome, thanks for helping me make this small contribution!

@madyankin
Copy link
Owner

I will release the new version by the end of the week

@jessethomson
Copy link
Contributor Author

Great, I look forward to it! Thanks for all you do!

@jessethomson
Copy link
Contributor Author

Can we get a new version released with this change? No rush. I know people have lives outside of open source projects so whenever you get some free time would be great 😄

@madyankin
Copy link
Owner

madyankin commented Jan 4, 2020 via email

@madyankin
Copy link
Owner

@jessethomson published. Sorry for keeping you waiting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants