allow async getJSON (& adapt saveJSON) #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madyankin
requested changes
Apr 30, 2017
src/saveJSON.js
Outdated
| writeFile( | ||
| `${ cssFile }.json`, | ||
| JSON.stringify(json), | ||
| e => e ? reject(e) : resolve()); |
There was a problem hiding this comment.
It can be useful to resolve the promise with the received json. Could you please make this?
|
@flying-sheep, great! I'll merge this today or tomorrow (on my phone right now). Thank you! |
|
@flying-sheep could you also fix the failing tests please? |
flying-sheep
force-pushed
the
getJSON-promise
branch
from
baab0ce
to
50cc156
Compare
|
OK, done! |
madyankin
approved these changes
Apr 30, 2017
|
@flying-sheep published |
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why not go the whole way with promises?
this way we don鈥檛 force people (e.g. me 馃槢) to use sync variants of IO functions.