Skip to content
This repository has been archived by the owner on Jan 20, 2024. It is now read-only.

[FEATURE] <A question submission box> (frontend) #59

Closed
ykdojo opened this issue Aug 13, 2022 · 41 comments · Fixed by #77 or #126
Closed

[FEATURE] <A question submission box> (frontend) #59

ykdojo opened this issue Aug 13, 2022 · 41 comments · Fixed by #77 or #126
Assignees
Labels
good first issue Good for newcomers

Comments

@ykdojo
Copy link
Collaborator

ykdojo commented Aug 13, 2022

Quoting myself from #10:

The first step is the signup flow as I mentioned at #14, and then after that, maybe a submission box? We can store them privately for now (probably in Supabase or Firebase), and once we have a few, we can make a view for showing those questions.

This should be possible to implement as we have #33 and #34 implemented already.

@ykdojo ykdojo added the good first issue Good for newcomers label Aug 13, 2022
@mark-omarov
Copy link
Contributor

Hi @ykdojo , how do you imagine the submission box to look like?
Also, what kind of features do you expect it to have? Is there a mockup or some kind of functional spec document?

@Preet-Sojitra
Copy link
Contributor

Hi @ykdojo , how do you imagine the submission box to look like? Also, what kind of features do you expect it to have? Is there a mockup or some kind of functional spec document?

Currently we have this #24

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 14, 2022

We should probably have the fields:

  • Company (FAANG+, or a custom textbox)
  • Location
  • Date
  • Question
  • Question description
  • Stay anonymous (check box)

Anything else?

@Jonyango
Copy link
Contributor

Jonyango commented Aug 14, 2022

What if we have a question category? I think it will be good to know what questions companies are mostly focused on.

@Jonyango
Copy link
Contributor

Would defaang be focusing on DSA questions, or will it also consist of system design and behavioural questions? @ykdojo

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 14, 2022

Having a question category sounds good.

Also forgot: the position name.

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 14, 2022

defaang will do both.

but I bet a lot of the questions will cover DSA

@Jonyango
Copy link
Contributor

That makes sense.

@Jonyango
Copy link
Contributor

If no one is working on this. I would love to take it. I haven't used Typescript before, but I believe I can make this work. Would you please assign this to me?

@Jonyango
Copy link
Contributor

@ykdojo Is the position the job title such as software engineer, or is it the levels such as L3?

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 14, 2022

The job title. Software Engineer, Site Reliability Engineer, Senior Software Engineer, etc.

@Jonyango
Copy link
Contributor

subscription box

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 14, 2022

Look good! I think the only required fields should be: Company and Question?

Now that I think about it, I'm not sure if we need the date for it since it'll be recorded anyway.

Maybe instead, it should ask "How recently was this question asked? Within the past: 1 month (default choice)" - and let the user pick any other # of months?

@Jonyango
Copy link
Contributor

That sounds okay. I will make the necessary changes.

@subhoghoshX
Copy link
Collaborator

LGTM. Make sure to add the "stay anonymous" checkbox as well. And I think the Category can also be a dropdown menu.

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 17, 2022

@Jonyango I'm not sure where you are on your progress, but I'm thinking of adding my contributions here.

In particular, I'm thinking of:

  • Simplifying the submission box somehow
  • Making it look good and attractive (and safe) for people to use it

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 17, 2022

The required fields:

  • Company (FAANG+, or a custom textbox)
  • Location
  • Date (how long ago was this asked?)
  • Question (100 char max?)
  • Question details
  • Stay anonymous (checkbox)

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 17, 2022

On stay anonymous, have a tooltip that says something like:

"This question will be associated with your account, but your account will not be shown publicly if this is checked. Later, you'll have an option to un-associate the question from your account completely so it won't even be on record."

@Jonyango
Copy link
Contributor

Jonyango commented Aug 18, 2022

Hey @ykdojo. I made the changes suggested on Sunday but haven't made much progress since then(I will get back on this on Friday). Would you like for me to incorporate the new changes you have suggested? Having some design would be helpful here so that I can recreate it faster. I saw that you asked @yaa-chi to help us with the design.

@yaa-chi
Copy link

yaa-chi commented Aug 18, 2022

Hi @Jonyango I have actually started with the design. Do check it out here: #82 (comment)

I am currently waiting for everyone to approve of it before We continue to the brand style guide.

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 18, 2022

@Jonyango yes! thank you.

Mind keeping us updated on your progress here as you work on it?

That way, I'll know where to potentially jump in, or maybe work on another area of the site, etc.

@yaa-chi
Copy link

yaa-chi commented Aug 18, 2022

Sure that's fine! @ykdojo I'm currently heading towards the logo design. We're done with color palette for both light and dark mode.

After the logo we're gonna go in with the font, and then finally the website layout for all screens.

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 18, 2022

Sounds good! For the website layout, could you keep Tailwind UI in mind as you go about it?

@yaa-chi
Copy link

yaa-chi commented Aug 18, 2022

Sure I will, both light and dark mode. I think it's better now that we have a direct inspiration of how the website will look like⚡🎉

@Jonyango
Copy link
Contributor

@Jonyango yes! thank you.

Mind keeping us updated on your progress here as you work on it?

That way, I'll know where to potentially jump in, or maybe work on another area of the site, etc.

Yes, I will do that.

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 19, 2022

@Jonyango just FYI, I think I'm going to try implementing this with Tailwind UI - in particular this one called simple stacked.

I'll keep updating this thread as I produce code so we don't duplicate work.

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 19, 2022

I just got the Application UI package!

Let me know if anyone wants to use any of the components.

@yaa-chi
Copy link

yaa-chi commented Aug 19, 2022

I just got the Application UI package!

Let me know if anyone wants to use any of the components.

Really? The premium one?😍

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 19, 2022

@ykdojo ykdojo self-assigned this Aug 19, 2022
@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 19, 2022

I have a draft PR here - feel free to work off of it if anyone feels like it while I'm away: #105

@yaa-chi
Copy link

yaa-chi commented Aug 19, 2022

I have a draft PR here - feel free to work off of it if anyone feels like it while I'm away: #105

YK please what's a draft PR😂😂

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 19, 2022

It's just a way to show your code changes, but you're not to have it be reviewed!

@yaa-chi
Copy link

yaa-chi commented Aug 19, 2022

oh ok, that's great! Github is really cool I'm learning a lot!

@Jonyango
Copy link
Contributor

@ykdojo, I am closing the draft PR I raised for this and will try to contribute to the one you have raised.

@Jonyango
Copy link
Contributor

So I didn't have to close it. I am confused as to why it shows that it was merged.

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 20, 2022

So I didn't have to close it. I am confused as to why it shows that it was merged.

That's kinda strange and I know GitHub does that sometimes - don't worry about it, though!

@ykdojo ykdojo changed the title [FEATURE] <A question submission box> [FEATURE] <A question submission box> (frontend) Aug 20, 2022
@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 20, 2022

Also I just renamed this to only include frontend. Made a new issue for the backend here: #108

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 24, 2022

@Jonyango any updates? If not, I'm thinking of continuing my work on #105

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 24, 2022

Moved it to #126 for simplicity (I had some rebasing issues)

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 24, 2022

Made a separate issue for styling at #127.

@Jonyango
Copy link
Contributor

@Jonyango, any updates? If not, I'm thinking of continuing my work on #105

Hey. You can continue your work at #105. Life has gotten in the way, and I won't be able to get to it for a while.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.