Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document "integration" with vscode flake8 plugin #26

Open
MatrixManAtYrService opened this issue Dec 16, 2022 · 2 comments
Open

Document "integration" with vscode flake8 plugin #26

MatrixManAtYrService opened this issue Dec 16, 2022 · 2 comments

Comments

@MatrixManAtYrService
Copy link

Perhaps this should have been obvious, but you can tell the vscode flake8 plugin to call pflake8 by placing this in .vscode/settings.json (presuming that poetry creates venv's called .venv in your project root as it does for me).

{
    "flake8.importStrategy": "fromEnvironment",
    "flake8.path": [
        ".venv/bin/pflake8"
    ],
}

If you don't feel like putting this in the readme, even just having this closed issue lying around might be enough to make this solution searchable.

@csachs
Copy link
Owner

csachs commented Dec 17, 2022

It can certainly be added to the README, do you like to open a PR or should I just add it?

@MatrixManAtYrService
Copy link
Author

I'll leave it to you to decide where it fits. "Anywhere, even in the issues comments" already scratches my itch and I'm not sure how far along the "integrations with particular editors" path you want to go.

I mean, pyproject-flake8 does its job (and very nicely!) so it wouldn't be unreasonable to be a bit standoffish about documenting things that are not pyproject-flake8 (e.g. vscode).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants