-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass lock metadata on uploads #4514
Draft
glpatcern
wants to merge
13
commits into
cs3org:master
Choose a base branch
from
glpatcern:locks-uploads
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
glpatcern
force-pushed
the
locks-uploads
branch
8 times, most recently
from
February 14, 2024 21:32
9a8b893
to
36a072a
Compare
glpatcern
changed the title
Pass lock holder metadata on uploads
Pass lock metadata on uploads
Feb 14, 2024
glpatcern
force-pushed
the
locks-uploads
branch
from
February 15, 2024 09:48
36a072a
to
6597fea
Compare
glpatcern
force-pushed
the
locks-uploads
branch
from
February 15, 2024 10:05
6597fea
to
a6e7ccf
Compare
glpatcern
force-pushed
the
locks-uploads
branch
from
February 27, 2024 16:06
2885699
to
fce392e
Compare
glpatcern
force-pushed
the
locks-uploads
branch
2 times, most recently
from
March 7, 2024 10:14
9e48ccf
to
f2854e1
Compare
glpatcern
force-pushed
the
locks-uploads
branch
from
March 29, 2024 07:19
d9cfec1
to
7d832dc
Compare
glpatcern
force-pushed
the
locks-uploads
branch
from
April 15, 2024 09:06
4c66e0f
to
2e8b265
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now pass relevant metadata (lock id and lock holder) downstream on uploads and on xattr operations, and handle the case of conflicts due to lock mismatch. The full implementation is only for eos (and requires eos 5.2.22+ on the server), cephfs is TODO.
Relates to cs3org/wopiserver#139