Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/sciencemesh/create-share defaults look wrong #3850

Open
michielbdejong opened this issue May 6, 2023 · 1 comment
Open

/sciencemesh/create-share defaults look wrong #3850

michielbdejong opened this issue May 6, 2023 · 1 comment

Comments

@michielbdejong
Copy link
Contributor

Looking at https://github.com/cs3org/reva/blob/master/internal/http/services/sciencemesh/share.go#L167-L170 it seems that that code is a confusion between default type = dir and default role = viewer.
Not type == viewer right?
@gmgigi96
Copy link
Member

gmgigi96 commented May 9, 2023

Correct! The type is directly mapped to the shareType in the OCM APIs, so the possible values are user, group or federation. For now reva only implements the user type and is indeed hard coded when creating the OCM share.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michielbdejong @gmgigi96