Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bip44-constants #19

Closed

Conversation

fanatid
Copy link
Member

@fanatid fanatid commented Feb 19, 2016

Resolve #18

@jprichardson
Copy link
Member

Thanks. Do you think that it makes sense to just remove the bip44 constants altogether? i.e. Just encourage people to use bip44-constants?

@fanatid
Copy link
Member Author

fanatid commented Feb 19, 2016

Do you think that it makes sense to just remove the bip44 constants altogether? i.e. Just encourage people to use bip44-constants?

Not sure. I think use all information about coin from one place it's nice.

@fanatid
Copy link
Member Author

fanatid commented Mar 17, 2016

@jprichardson you don't forget about this PR?
probably this PR need major bump, because I change some coin names for consistent with bip44-constants

@jprichardson
Copy link
Member

Do we want to return the number with the ' or without? e.g. for Dogecoin, should we be returning:

bip44Constants.Dogecoin - 0x80000000 or bip44Constants.Dogecoin

??

@fanatid
Copy link
Member Author

fanatid commented Mar 22, 2016

Why you want this? SLIP-0044 has numbers with '

@jprichardson
Copy link
Member

Why you want this? SLIP-0044 has numbers with '

Exactly. Since when you pass the constant to a derive() function, you typically need the ' (bip44Constants.Dogecoin) instead of (bip44Constants.Dogecoin + 0x80000000).

But since all have 0x80000000, it could make it hard to detect differences. IDK, I'm probably splitting hairs here.

@fanatid
Copy link
Member Author

fanatid commented Mar 22, 2016

maybe return two constants? one with ' and one without '?

@jprichardson
Copy link
Member

Hmmm, still thinking about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove bip44 constants.
3 participants