Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Select default permissions that do not use FlightRecorder/Recording #979

Closed
ebaron opened this issue Jun 3, 2022 · 3 comments · Fixed by #1042
Closed

[Task] Select default permissions that do not use FlightRecorder/Recording #979

ebaron opened this issue Jun 3, 2022 · 3 comments · Fixed by #1042
Assignees
Labels
feat New feature or request

Comments

@ebaron
Copy link
Member

ebaron commented Jun 3, 2022

After #635, we can modify which Cryostat permissions map to which Kubernetes RBAC permissions. Now we should modify the default Kubernetes permissions from their current values. Since the FlightRecorder and Recordings APIs will soon be removed, we have to pick some alternatives. Ideally these would not depend on CRDs shipped with the operator, but that's not a hard requirement, it would simply allow for more flexibility.

@andrewazores
Copy link
Member

It's also possible that the downstream build carries a patch for Operator-supplied CRDs. Or maybe the upstream Operator can even carry its own whole .properties file and mount that to the Cryostat container in place of the default upstream one.

@tthvo
Copy link
Member

tthvo commented Aug 16, 2022

After reading through the OAuth setup,

For TARGET, I think it mostly needs permissions for pods, deployments.

For RECORDING, it is not easy to choose a mapping but I guess we could just have it as cryostats.operator.cryostat.io similar to CREDENTIAL since they are created, stored and accessed in somehow similar fashion.

Not sure I worded it right. Any thoughts @ebaron @andrewazores?

@ebaron
Copy link
Member Author

ebaron commented Aug 16, 2022

I feel like the pod/exec subresource captures what we're doing here with recordings. The create pod/exec permission allows you to run arbitrary commands in the pod using kubectl exec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants