Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] Compression for Archived Recordings #732

Open
andrewazores opened this issue Oct 19, 2021 · 2 comments · May be fixed by #1112
Open

[Task] Compression for Archived Recordings #732

andrewazores opened this issue Oct 19, 2021 · 2 comments · May be fixed by #1112
Assignees
@lkonno
Labels
feat New feature or request needs-documentation

Comments

@andrewazores
Copy link
Member

We should support some kind of on-disk compression for archived recordings to save disk space. Here's a blog that looks at the topic of compressing JFR binaries using various compression algorithms:

http://hirt.se/blog/?p=1166

We likely just want to support one algorithm, and the implementation for it should be easily available for downstream builds as well. The compression should be enabled by default, but it should be possible to disable it by an environment variable, in case the end user would prefer to remove the compression CPU overhead and trade off for increased disk space usage, or in case the mounted archive filesystem is already doing transparent compressions, etc.

Should we also apply this compression to custom templates and to generated reports that are cached for archived recordings?
@andrewazores andrewazores added the feat New feature or request label Oct 19, 2021
@andrewazores andrewazores mentioned this issue Dec 23, 2021
Merged
@andrewazores andrewazores changed the title Compression for Archived Recordings [Task] Compression for Archived Recordings May 17, 2022
@lkonno lkonno self-assigned this Oct 6, 2022
@lkonno
Copy link
Contributor

lkonno commented Oct 6, 2022

I started looking this and I am planning to use the GZIP implementation from java.util.zip package in the archived recording files.

@andrewazores
Copy link
Member Author

Yes, I think archived recording files is the most important thing to compress, since they're naturally just far larger and far more prevalent than the other things I named (custom template XML, automated rule JSON, report HTML).

The built-in GZIP sounds like a good choice, at least to start with. Perhaps in the future we can extend this to allow the user to select other algorithms like LZ4 or LZMA, too.

@lkonno lkonno linked a pull request Oct 12, 2022 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lkonno lkonno

Labels
feat New feature or request needs-documentation
Projects
No open projects
2.2.0 Release
Status: Stretch Goals
2.3.0 release
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(archives): gzip archived recordings lkonno/cryostat
2 participants
@andrewazores @lkonno