Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local extensions cannot be updated #253

Open
Chilipp opened this issue May 31, 2023 · 0 comments · May be fixed by #254
Open

Local extensions cannot be updated #253

Chilipp opened this issue May 31, 2023 · 0 comments · May be fixed by #254

Comments

@Chilipp
Copy link
Contributor

Chilipp commented May 31, 2023

In #237 we implemented support for local extensions. However, if you do an cruft update and one of these extensions have been changed (e.g. new filters have been added), then the update breaks because the extension module has already been imported and has not been updated in sys.modules.

I will create a PR for this
@Chilipp Chilipp mentioned this issue May 31, 2023
Draft
Chilipp added a commit to Chilipp/cruft that referenced this issue May 31, 2023
@Chilipp
remove modules after sys.path has been changed
1f74151 
to make sure we do not keep them during the update, see cruft#253
Chilipp added a commit to Chilipp/cruft that referenced this issue May 31, 2023
@Chilipp
implement test for local extension update
71a0a65 
see cruft#253
@Chilipp Chilipp linked a pull request May 31, 2023 that will close this issue
Draft
2 tasks
Chilipp added a commit to Chilipp/cookiecutter-test that referenced this issue May 31, 2023
@Chilipp
add a new filter in the local extensions
c9649fd 
see cruft/cruft#253
Chilipp added a commit to Chilipp/cookiecutter-test that referenced this issue May 31, 2023
@Chilipp
add a new filter in the local extensions
a3b3fda 
see cruft/cruft#253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

implement support for local extensions update Chilipp/cruft
1 participant
@Chilipp