Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert support for negative timestamps on Windows #745

Merged

Conversation

systemcatch
Copy link
Collaborator

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 📚 Updated documentation for changed code.
  • ⏩ Code is up-to-date with the master branch.

If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!

Description of Changes

Reverts #700 entirely due to https://github.com/crsmithdev/arrow/blob/master/tests/util_tests.py#L58 causing intermittent test (and hence build) failures. There is also some debate whether the feature is actually returning correct answers due to DST causing problems.

ref #675
/cc @kkoziara

@codecov-io
Copy link

codecov-io commented Jan 1, 2020

Codecov Report

Merging #745 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #745   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines        1678   1655   -23     
  Branches      283    279    -4     
=====================================
- Hits         1678   1655   -23
Impacted Files Coverage Δ
arrow/util.py 100% <100%> (ø) ⬆️
arrow/parser.py 100% <100%> (ø) ⬆️
arrow/arrow.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70fb905...d15b681. Read the comment docs.

Copy link
Member

@jadchaar jadchaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@systemcatch systemcatch merged commit 1cd7f94 into arrow-py:master Jan 1, 2020
@jadchaar jadchaar mentioned this pull request Jan 1, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants