Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Hong Kong (zh_hk) locale #742

Merged
merged 1 commit into from Jan 1, 2020
Merged

Added Hong Kong (zh_hk) locale #742

merged 1 commit into from Jan 1, 2020

Conversation

sunnz
Copy link
Contributor

@sunnz sunnz commented Dec 29, 2019

Pull Request Checklist

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 📚 Updated documentation for changed code.
  • ⏩ Code is up-to-date with the master branch.

Description of Changes

Added Hong Kong (zh_hk) locale with its unit test

@codecov-io
Copy link

codecov-io commented Dec 29, 2019

Codecov Report

Merging #742 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #742   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines        1678   1687    +9     
  Branches      283    283           
=====================================
+ Hits         1678   1687    +9
Impacted Files Coverage Δ
arrow/locales.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70fb905...a75f3bb. Read the comment docs.

Copy link
Member

@jadchaar jadchaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jadchaar jadchaar merged commit 6a70b9d into arrow-py:master Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants