allowing plural 'name' arguments to _get_frames #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #735 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 9
Lines 1667 1669 +2
Branches 281 282 +1
=====================================
+ Hits 1667 1669 +2
Continue to review full report at Codecov.
|
JunhwanK
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:
toxormake testto find out!).masterbranch.If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!
Description of Changes
This change allows _get_frames to prase plural forms of the 'frame' argument (e.g. "day" and "days").
This change reduces confusion in users by providing them with more consistent function interfaces that accept both singular and plural 'frames' arguments, instead of the current interface that accepts "weeks" and "quarters" but not "days" or "hours".
Closes: #298