New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for multiple granularities in humanize #722
Conversation
Codecov Report
@@ Coverage Diff @@
## master #722 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 9
Lines 1606 1678 +72
Branches 266 283 +17
=====================================
+ Hits 1606 1678 +72
Continue to review full report at Codecov.
|
@jadchaar do you have any comments or feedback for these commits? |
Hey @hwillard98, apologies for the delayed response. I was quite busy this holiday weekend. At first glance, the work looks solid, but I'd like to take a closer look when I get some more free time. I talked to @systemcatch and he said he will review these PRs today as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall a brilliant PR. I need to look at your logic a bit more, but I had a bit of feedback off the bat: I would add a bit of documentation explaining and showing examples for your new feature here: https://github.com/crsmithdev/arrow/blob/master/docs/index.rst.
@hwillard98 thanks for the quick updates. Mind adding a section to the main documentation (you should add it to this file: https://github.com/crsmithdev/arrow/blob/master/docs/index.rst)? It should go in the Humanize section: https://arrow.readthedocs.io/en/latest/#humanize |
Any other changes requested? I added the documentation in the most recent commit amend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hwillard98, I only have one extra comment which is really a style preference, feel free to deal with it however you want.
Otherwise I think this PR is great and ready to go. @jadchaar any further comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes we commented on previously. I got some time to look at this closer and I had a few remaining comments. Should be good to merge after these are addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for implementing the feedback quickly 👍 .
This implements a feature in #716 to use multiple granularities as an input to humanize.
For example,