Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.15.3 tarball does not include license, tests, docs... #710

Closed
bollwyvl opened this issue Nov 3, 2019 · 3 comments
Closed

0.15.3 tarball does not include license, tests, docs... #710

bollwyvl opened this issue Nov 3, 2019 · 3 comments

Comments

@bollwyvl
Copy link
Contributor

bollwyvl commented Nov 3, 2019

Thanks for arrow, and congratulations on the release!

The change in #679 caused the released source distribution to not include the LICENSE, the tests, or the docs source.

Test:

curl -O https://files.pythonhosted.org/packages/ee/03/89730d72d6c13aee381508eb0516168546ed6f08a4bf8f5b24522ed23491/arrow-0.15.3.tar.gz
tar -xaf arrow-0.15.3.tar.gz
cat arrow-0.15.3/LICENSE
>>> cat: arrow-0.15.3/LICENSE: No such file or directory

The wheel includes the license (through separate metadata), but not the tests. Downstreams, such as conda-forge use these to ensure repackaging.

Will make a PR to put the .in back into MANIFEST!

@jadchaar
Copy link
Member

jadchaar commented Nov 3, 2019

Hi @bollwyvl, thanks for reporting this. I will get the fix merged and ship v0.15.4 ASAP.

jadchaar added a commit that referenced this issue Nov 3, 2019
Renaming of MANIFEST back to MANIFEST.in
@jadchaar jadchaar closed this as completed Nov 3, 2019
@bollwyvl
Copy link
Contributor Author

bollwyvl commented Nov 3, 2019

Thank you for the speedy review and merge!

@jadchaar
Copy link
Member

jadchaar commented Nov 3, 2019

@bollwyvl renaming was totally a mistake on my end--I read somewhere that MANIFEST could be used instead and I wanted to line up the naming with LICENSE, but I guess that is not the case.

I have published v0.15.4 with the fixed packaging. Thanks again for reporting this :D!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants