Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reviewer(s) when creating a pull-request #145

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

ultr4nerd
Copy link
Contributor

Done! I have already tested it and works perfectly! Let me know if it looks good for you.

Also, I think that you could open an issue for adding team reviewers to a pull request. It would be a great feature. I know is possible but I'm not sure how to do it the best way possible with bash.

@andrii-bodnar andrii-bodnar linked an issue Oct 28, 2022 that may be closed by this pull request
@andrii-bodnar
Copy link
Member

@ultr4nerd looks good to me, thanks a lot for your contribution! 🚀

I know is possible but I'm not sure how to do it the best way possible with bash.

Could it be a different approach than the current features?

@andrii-bodnar andrii-bodnar merged commit 3290f6b into crowdin:master Oct 28, 2022
@ultr4nerd
Copy link
Contributor Author

@andrii-bodnar Is adding other field to the request, to add teams as reviewers

@andrii-bodnar
Copy link
Member

@ultr4nerd and it can't be passed with the requested_reviewers simultaneously in one request, right?

@ultr4nerd
Copy link
Contributor Author

No, actually it's possible, but I wasn't able to make it work ☹️

@andrii-bodnar
Copy link
Member

@ultr4nerd let's see if this feature will be requested by Action users and then will try to solve that 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add reviewer(s) when creating a pull-request
2 participants