Skip to content

Encode the Crowdin-API-FileName #188

New issue
New issue
Closed
#190
Closed
Encode the Crowdin-API-FileName#188
#190
Assignees
ade1705
Labels
bugSomething isn't workingenhancementNew feature or requestgood first issueGood for newcomershacktoberfestThis issue welcomes contributions for Hacktoberfest
@andrii-bodnar

Description

@andrii-bodnar
andrii-bodnar
opened on Oct 5, 2022

According to the documentation, the Crowdin-API-FileName header value should be url encoded.

crowdin-api-client-js/src/uploadStorage/index.ts

Line 958 in b0a1e53

config.headers['Crowdin-API-FileName'] = fileName;

Currently, this value is not encoded and that is causing issues with uploading files, for example, with Cyrillic file names.

Also, a new test case should be added

crowdin-api-client-js/tests/uploadStorage/api.test.ts

Line 4 in e1f70b5

describe('Upload Storage API', () => {

Activity

andrii-bodnar
added
bugSomething isn't working
enhancementNew feature or request
hacktoberfestThis issue welcomes contributions for Hacktoberfest
good first issueGood for newcomers
on Oct 5, 2022
ade1705

ade1705 commented on Oct 6, 2022

@ade1705
ade1705
on Oct 6, 2022
Contributor

Hi @andrii-bodnar I would like to work on this issue.

andrii-bodnar

andrii-bodnar commented on Oct 6, 2022

@andrii-bodnar
andrii-bodnar
on Oct 6, 2022
MemberAuthor

Hi @ade1705 great, thank you!
Assigning this issue to you

andrii-bodnar
assigned
ade1705
on Oct 6, 2022
ade1705
added a commit that references this issue on Oct 10, 2022

crowdin#188 - Encode the Crowdin-API-FileName

95773d4
ade1705

ade1705 commented on Oct 10, 2022

@ade1705
ade1705
on Oct 10, 2022
Contributor

@andrii-bodnar Please have a look at this PR here

ade1705
added a commit that references this issue on Oct 11, 2022

crowdin#188 - Encode the Crowdin-API-FileName - Changed test file name

47d4978
andrii-bodnar
linked a pull request that will close this issue#188 - Encode the Crowdin-API-FileName #190on Oct 11, 2022
ade1705
added a commit that references this issue on Oct 11, 2022

crowdin#188 - Encode the Crowdin-API-FileName - Added a non-Cyrillic …

f4a5c22
andrii-bodnar
added a commit that references this issue on Oct 12, 2022

Merge pull request #190 from ade1705/#188-Encode_the_Crowdin-API-File…

106ea58
andrii-bodnar
closed this as completedin #190on Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingenhancementNew feature or requestgood first issueGood for newcomershacktoberfestThis issue welcomes contributions for Hacktoberfest

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @andrii-bodnar@ade1705

    Issue actions
      Encode the Crowdin-API-FileName · Issue #188 · crowdin/crowdin-api-client-js