Add extra modifiers/state from kitty keyboard protocol #696

pianohacker · 2022-08-01T06:13:52Z

Add support for:

The Super/Command/Windows modifier.
The Hyper/Meta modifers (stored in the state field as discussed in a previous PR).
The Num Lock/Caps Lock state.

Please especially review the solution for Hyper/Meta.

This will only work in a terminal supporting the kitty keyboard protocol.

groves

Excited to see the addition of super! Always wanted to be able to use that from the terminal.

src/event.rs

TimonPost

Looks awesome!!

pianohacker added 4 commits August 1, 2022 00:09

Add support for Super, Hyper, and Meta modifiers

b9a363f

This will only work in a terminal supporting the kitty keyboard protocol.

Fix modifier parsing for release events for special keys

7994d73

Move Hyper/Meta into state field, add Num/Caps Lock to state field

ef684f9

Fix docs error

4417f62

pianohacker requested a review from TimonPost as a code owner August 1, 2022 06:13

Fix clippy error

07c1813

groves reviewed Aug 2, 2022

View reviewed changes

src/event.rs Outdated Show resolved Hide resolved

pianohacker added 2 commits August 2, 2022 23:07

Move Hyper/Meta back to modifiers

6e22b97

Add keyboard enhancement flags to event-read example

7345feb

TimonPost approved these changes Aug 10, 2022

View reviewed changes

TimonPost merged commit 2a612e0 into crossterm-rs:master Aug 10, 2022

TimonPost mentioned this pull request Jan 12, 2023

Support new terminal protocol for extended keys and more modifiers #569

Closed

Provide feedback