Increase support for kitty enhanced keyboard protocol #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add parsing of repeat/release key events, and allow sending the CSIs to enable/disable the enhanced keyboard protocol. See https://sw.kovidgoyal.net/kitty/keyboard-protocol/ for more information.
|
Interesting. Would be nice to see the modifiers like Meta implemented as well https://sw.kovidgoyal.net/kitty/keyboard-protocol/#modifiers in a followup. Lots of people commented on that and this protocol seems to allow fetching it |
TimonPost
reviewed
Jul 22, 2022
|
Agreed; I didn't want to add too much at once, but the extra modifiers would be great. I'd also like to add support for https://sw.kovidgoyal.net/kitty/keyboard-protocol/#functional-key-definitions , but that's a weighty PR. |
|
I ended up adding support for the functional keys, as otherwise they end up as unicode gibberish: pianohacker/crossterm@pianohacker_add_csi_u_types...pianohacker:crossterm:pianohacker_add_functional_keys I'll create a PR for that after this one. |
TimonPost
approved these changes
Jul 24, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parsing of repeat/release key events, and allow sending the CSIs to enable/disable the enhanced keyboard protocol.
See https://sw.kovidgoyal.net/kitty/keyboard-protocol/ for more information.
Note: this changes the form of the
KeyEventstruct.