Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the SetStyle tuple struct #687

Merged
merged 2 commits into from Jul 21, 2022
Merged

Conversation

AhoyISki
Copy link
Contributor

@AhoyISki AhoyISki commented Jul 5, 2022

This is a pretty simple PR, it just creates a command for setting a style, given a ContentStyle. This style will be applied to all subsequent text, like Set(Foreground|Background|Underline)Color or SetAttribute(s).

This command is mostly for convenience, letting the user execute the aforementioned commands within just a single one.

PS: I know this is a breaking change, but shouldn't ResetColorreally be called ResetStyle, since it also resets attributes?

@AhoyISki AhoyISki requested a review from TimonPost as a code owner July 5, 2022 15:17
@AhoyISki
Copy link
Contributor Author

Do you plan to merge this?

@TimonPost
Copy link
Member

Yes, thanks for the reminder.

@TimonPost
Copy link
Member

Nice!

@TimonPost TimonPost merged commit 4dcc6fc into crossterm-rs:master Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants