Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug logs should use RFC3339 timestamps (again?) #373

Closed
negz opened this issue Jan 23, 2023 · 1 comment · Fixed by #375
Closed

Debug logs should use RFC3339 timestamps (again?) #373

negz opened this issue Jan 23, 2023 · 1 comment · Fixed by #375
Labels
bug Something isn't working

Comments

@negz
Copy link
Member

negz commented Jan 23, 2023

What happened?

It seems like (at least in debug mode) our logger is now using epoch time. I'm 99% sure it used to use RFC3339 when in debug mode, which would make sense since epochs are fairly meaningless to human readers.

crossplane-contrib/provider-aws#1626
kubernetes-sigs/controller-runtime#2029

How can we reproduce it?

What environment did it happen in?

Crossplane version:

We should pass the required args to get RFC3339 timestamps - see linked PRs above.

@negz negz added the bug Something isn't working label Jan 23, 2023
@negz
Copy link
Member Author

negz commented Jan 25, 2023

Actually, the linked controller-runtime PR is included in https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.14.0 so this will be fixed by #375.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant