Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling all Rust targets. #931

Closed
MediosZ opened this issue Nov 22, 2022 · 2 comments · Fixed by #932
Closed

Handling all Rust targets. #931

MediosZ opened this issue Nov 22, 2022 · 2 comments · Fixed by #932
Labels
bug crossbeam-epoch crossbeam-queue crossbeam-utils

Comments

@MediosZ
Copy link

MediosZ commented Nov 22, 2022

I notice that in this commit, we try to replace vendor in targets. But it presumes that all targets are triplets, which doesn't hold for some targets like wasm32-wasi and x86_64-fuchsia. This causes problems when compiling crossbeam for these targets.

I can fix this if needed or maybe there are better solutions.
@taiki-e
Copy link
Member

taiki-e commented Nov 22, 2022

Thanks for the report! I yanked the versions affected by this bug.

I believe the ideal solution here is to use cfg_target_has_atomic on Rust 1.60+ like my portable-atomic crate does.

@taiki-e taiki-e mentioned this issue Nov 22, 2022
Merged
bors bot added a commit that referenced this issue Nov 22, 2022
@bors @Cryptex-github
Merge #932
041ae78 
932: Fix panicking when target triplets has less than three elements r=taiki-e a=Cryptex-github

Currently the build script panic when the target triplets have less than three elements, for example `wasm32-wasi`, this PR fixes that issue.

Fixes #931

Co-authored-by: Cryptex <64497526+Cryptex-github@users.noreply.github.com>
@bors bors bot closed this as completed in 9b56854 Nov 22, 2022
@taiki-e
Copy link
Member

taiki-e commented Nov 22, 2022

Fixed in crossbeam-utils 0.8.14, crossbeam-queue 0.3.8, and crossbeam-epoch 0.9.13. (#932)

kayabaNerve added a commit to serai-dex/serai that referenced this issue Nov 23, 2022
@kayabaNerve
cargo update
00c1f21 
Resolves yanking of crossbeam (see crossbeam-rs/crossbeam#931).
@taiki-e taiki-e mentioned this issue Dec 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug crossbeam-epoch crossbeam-queue crossbeam-utils
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix panicking when target triple has less than three elements Cryptex-github/crossbeam
2 participants
@MediosZ @taiki-e