When building for linux, replace all vendors with 'unknown' #922
+25
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some build systems such as the Yocto project define custom rust targets, of the form 'arch-somevendor-linux-gnu/musl' (only the 'somevendor' part is custom, the rest matches rust's definitions). This causes mismatches with crossbeam's lists of targets which are built from the standard rust target list, and always have 'unknown' as the vendor. This change simply replaces such custom vendors with 'unknown' when the third component of the target is 'linux'.
|
Thanks! This looks good to me. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 20, 2022
929: v0.8: Prepare for the next release r=taiki-e a=taiki-e Backports #922 and #926. Changes: - crossbeam-utils 0.8.12 -> 0.8.13 - Update `memoffset` to 0.7. (#926) - Improve support for custom targets. (#922) - crossbeam-queue 0.3.6 -> 0.3.7 - Improve support for custom targets. (#922) - crossbeam-epoch 0.9.11 -> 0.9.12 - Improve support for custom targets. (#922) Closes #928 Co-authored-by: Taiki Endo <te316e89@gmail.com> Co-authored-by: Alexander Kanavin <alex@linutronix.de> Co-authored-by: Griffin Smith <root@gws.fyi>
bors bot
added a commit
that referenced
this pull request
Nov 20, 2022
929: v0.8: Prepare for the next release r=taiki-e a=taiki-e Backports #922 and #926. Changes: - crossbeam-utils 0.8.12 -> 0.8.13 - Update `memoffset` to 0.7. (#926) - Improve support for custom targets. (#922) - crossbeam-queue 0.3.6 -> 0.3.7 - Improve support for custom targets. (#922) - crossbeam-epoch 0.9.11 -> 0.9.12 - Improve support for custom targets. (#922) Closes #928 Co-authored-by: Taiki Endo <te316e89@gmail.com> Co-authored-by: Alexander Kanavin <alex@linutronix.de> Co-authored-by: Griffin Smith <root@gws.fyi>
|
Published in crossbeam-utils 0.8.13, crossbeam-queue 0.3.7, and crossbeam-epoch 0.9.12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some build systems such as the Yocto project define custom rust targets, of the form 'arch-somevendor-linux-{gnu|musl}' (only the 'somevendor' part is custom, the rest matches rust's definitions).
This causes mismatches with crossbeam's lists of targets which are built from the standard rust target list, and always have 'unknown' as the vendor.
This change simply replaces such custom vendors with 'unknown' when the third component of the target is 'linux'.
Note from Alex: this is a reworked and hopefully better/more precise/acceptable version of #751