channel: Replace Spinlock with Mutex #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✌️ ibraheemdev can now approve this pull request. To approve and merge a pull request, simply reply with |
|
A better design might be to use an intrusive linked list for wakers, which could avoid allocations entirely in the critical section, but this seems like a good change either way. Thanks! |
|
@bors r+ |
|
bors r=ibraheemdev (The command of bors used in rust-lang is |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Jun 16, 2022
850: Prepare for the next release r=taiki-e a=taiki-e - crossbeam-channel 0.5.4 -> 0.5.5 - Replace Spinlock with Mutex. (#835) - crossbeam-epoch 0.9.8 -> 0.9.9 - Replace lazy_static with once_cell. (#817) - crossbeam-utils 0.8.8 -> 0.8.9 - Replace lazy_static with once_cell. (#817) Co-authored-by: Taiki Endo <te316e89@gmail.com>
bors bot
added a commit
that referenced
this pull request
Jun 16, 2022
850: Prepare for the next release r=taiki-e a=taiki-e - crossbeam-channel 0.5.4 -> 0.5.5 - Replace Spinlock with Mutex. (#835) - crossbeam-epoch 0.9.8 -> 0.9.9 - Replace lazy_static with once_cell. (#817) - crossbeam-utils 0.8.8 -> 0.8.9 - Replace lazy_static with once_cell. (#817) Co-authored-by: Taiki Endo <te316e89@gmail.com>
ti-chi-bot
added a commit
to tikv/tikv
that referenced
this pull request
Nov 17, 2022
close #13815 According to crossbeam-rs/crossbeam#835, spinning at the sending side is probably a bad idea because of large critical section and it's fixed in the recent version. This commit updates crossbeam-channel. It will reduce CPU usage a bit and improve performance. Signed-off-by: Yilin Chen <sticnarf@gmail.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses one of @thomcc's reviews in rust-lang/rust#93563 (comment) (sorry for the late response!)
Historically, the use of spinlock was introduced when the dependency on parking_lot was removed (5208895).
However, given that it is used in Waker, which includes vectors that may be reallocated, using mutex seems to be the right choice here.
r? @ibraheemdev
bors d=ibraheemdev