added get_or_insert_with function #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Could you add a test for the case where the closure panics? (related #717) |
…ere closure panics.
|
I have added two test cases - (a) for valid case (b) where closure panics. Please check if this is what you are looking at. Thanks |
|
@taiki-e - pls update here. |
taiki-e
reviewed
Jul 22, 2021
|
Also, it would make sense to add the same method to SkipMap |
taiki-e
reviewed
Jul 22, 2021
As suggested by taiki-e Co-authored-by: Taiki Endo <te316e89@gmail.com>
…n case another thread writes before. 2) Added test case for the same.
Sure, will do. |
2) Added corresponding test case for SkipMap
|
@taiki-e - added corresponding method and test for SkipMap. For SkipSet, as value is always () it may not make sense. Please review. Thanks |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_or_insert_with function allows lazy creation of default value. Default values may be heavy objects, lazy creation doesn't create un-necessary objects when key is already there in the data structure.