Add {Atomic, Shared}::try_into_owned #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
approved these changes
May 28, 2022
bors bot
added a commit
that referenced
this pull request
May 28, 2022
701: Add {Atomic, Shared}::try_into_owned r=taiki-e a=PatrickNorton
Sometimes, I have run into times when I have had an `Atomic` which I know to be either null or valid, and I want to convert it into an `Owned`. As far as I can tell, there is no way to do this without converting through a `Shared`, which comes at the const of an additional atomic load. This pull request also adds the same method to `Shared` for symmetry.
This pull request adds the following methods:
```rust
impl<T: ?Sized + Pointable> Owned<T> {
pub unsafe fn try_into_owned(self) -> Option<Owned<T>>;
}
impl<T: ?Sized + Pointable> Shared<'_, T> {
pub unsafe fn try_into_owned(self) -> Option<Owned<T>>;
}
```
Co-authored-by: Patrick Norton <patrick.147.norton@gmail.com>
taiki-e
reviewed
May 28, 2022
|
Canceled. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 28, 2022
701: Add {Atomic, Shared}::try_into_owned r=taiki-e a=PatrickNorton
Sometimes, I have run into times when I have had an `Atomic` which I know to be either null or valid, and I want to convert it into an `Owned`. As far as I can tell, there is no way to do this without converting through a `Shared`, which comes at the const of an additional atomic load. This pull request also adds the same method to `Shared` for symmetry.
This pull request adds the following methods:
```rust
impl<T: ?Sized + Pointable> Owned<T> {
pub unsafe fn try_into_owned(self) -> Option<Owned<T>>;
}
impl<T: ?Sized + Pointable> Shared<'_, T> {
pub unsafe fn try_into_owned(self) -> Option<Owned<T>>;
}
```
Co-authored-by: Patrick Norton <patrick.147.norton@gmail.com>
Co-authored-by: Taiki Endo <te316e89@gmail.com>
|
Timed out. |
taiki-e
reviewed
Jul 19, 2022
Co-authored-by: Taiki Endo <te316e89@gmail.com>
|
bors r+ |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Jul 23, 2022
880: Prepare for the next release r=taiki-e a=taiki-e - crossbeam-channel 0.5.5 -> 0.5.6 - Bump the minimum supported Rust version to 1.38. (#877) - crossbeam-deque 0.8.1 -> 0.8.2 - Bump the minimum supported Rust version to 1.38. (#877) - crossbeam-epoch 0.9.9 -> 0.9.10 - Bump the minimum supported Rust version to 1.38. (#877) - Mitigate the risk of segmentation faults in buggy downstream implementations. (#879) - Add `{Atomic, Shared}::try_into_owned` (#701) - crossbeam-queue 0.3.5 -> 0.3.6 - Bump the minimum supported Rust version to 1.38. (#877) - crossbeam-utils 0.8.10 -> 0.8.11 - Bump the minimum supported Rust version to 1.38. (#877) - crossbeam 0.8.1 -> 0.8.2 - Bump the minimum supported Rust version to 1.38. (#877) Co-authored-by: Taiki Endo <te316e89@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, I have run into times when I have had an
Atomicwhich I know to be either null or valid, and I want to convert it into anOwned. As far as I can tell, there is no way to do this without converting through aShared, which comes at the const of an additional atomic load. This pull request also adds the same method toSharedfor symmetry.This pull request adds the following methods: