Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We need to test i686 linux-gnu on CI by using cross #598

Closed
jeehoonkang opened this issue Nov 13, 2020 · 0 comments · Fixed by #613
Closed

We need to test i686 linux-gnu on CI by using cross #598

jeehoonkang opened this issue Nov 13, 2020 · 0 comments · Fixed by #613
Assignees
@taiki-e

Comments

@jeehoonkang
Copy link
Contributor

Ideally, we need to test i686 linux-gnu on CI by using cross. (We are not currently testing platforms other than x86_64 linux&windows.)
However, some of the channel tests (deadline/timeout-related) are pretty fragile. (After all, that's why #578 and #591 can't be merged yet. That's also why macOS hasn't been tested in CI.)

Originally posted by @taiki-e in #597 (comment)
@jeehoonkang jeehoonkang mentioned this issue Nov 13, 2020
Merged
bors bot added a commit that referenced this issue Nov 22, 2020
@bors @jeehoonkang
Merge #599
8d97617 
599: Relaxed size constrait of Local (closes #597) r=taiki-e a=jeehoonkang

@decathorpe Thank you for reporting this.  It's also kinda hotfix.  As @taiki-e said, we really need CI for i686 and other 32-bit architectures... (#598).

r? @taiki-e 

Co-authored-by: Jeehoon Kang <jeehoon.kang@kaist.ac.kr>
bors bot added a commit that referenced this issue Nov 22, 2020
@bors @jeehoonkang
Merge #599
262f94d 
599: Relaxed size constrait of Local (closes #597) r=taiki-e a=jeehoonkang

@decathorpe Thank you for reporting this.  It's also kinda hotfix.  As @taiki-e said, we really need CI for i686 and other 32-bit architectures... (#598).

r? @taiki-e 

Co-authored-by: Jeehoon Kang <jeehoon.kang@kaist.ac.kr>
@taiki-e taiki-e mentioned this issue Dec 9, 2020
Merged
@taiki-e taiki-e self-assigned this Dec 31, 2020
@bors bors bot closed this as completed in a66fe72 Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taiki-e taiki-e

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test i686-unknown-linux-gnu and aarch64-unknown-linux-gnu on CI crossbeam-rs/crossbeam
2 participants
@jeehoonkang @taiki-e