Updates to Parker
#563
Merged
Updates to Parker
#563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
reviewed
Nov 20, 2020
There was a problem hiding this comment.
Thanks for the PR and sorry for the delay reviewing! The implementation looks good, but we recently released a new minor version of crossbeam-utils, so I would prefer not to do the breaking changes right now.
It might make sense to consider doing this in a future version (filed #601 to follow-up), but for now, can you revert the changes for UnparkReason?
taiki-e
added
the
S-waiting-on-author
|
Sure thing, I'll get to it this weekend. |
|
Done. Preserved the old version in a branch: https://github.com/Lucretiel/crossbeam/tree/unpark-reason |
taiki-e
removed
S-waiting-on-author
|
CI failures seem unrelated; they're being caused by an issue with rustup. |
|
CI failure was fixed in #606. Could you rebase? |
- No longer possibility for spurious wake - Now reports unpark reason (timeout or unpark())Updates to parker
Remove checked_duration_since in favor of arithmetic and manual checks
`UnparkReason` implementation preserved in Lucretiel/crossbeam/unpark-reason
Lucretiel
force-pushed
the
parker-updates
branch
from
927c3f8
to
4c0a106
Compare
|
Done |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Feb 20, 2021
659: Prepare for the next release r=taiki-e a=taiki-e It's been over two months since the previous release. There are some improvements and deprecations in the master branch, and it would be nice to release them. Also, there is no breaking change that needs a major version bump. Changes: - crossbeam-epoch 0.9.1 -> 0.9.2 - Add `Atomic::compare_exchange` and `Atomic::compare_exchange_weak`. (#628) - Deprecate `Atomic::compare_and_set` and `Atomic::compare_and_set_weak`. (#628) - Make `const_fn` dependency optional. (#611) - Add unstable support for `loom`. (#487) - crossbeam-utils 0.8.1 -> 0.8.2 - Deprecate `AtomicCell::compare_and_swap`. (#619) - Add `Parker::park_deadline`. (#563) - Improve implementation of `CachePadded`. (#636) - Add unstable support for `loom`. (#487) Co-authored-by: Taiki Endo <te316e89@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
park: now deadline based, and unified the code paths between timeout and no-timeout versionsBreaking Changepark_timeoutandpark_deadlinenow report the reason for their return (timeout orunpark) in an enum.If you'd rather not have this breaking change, I'm happy to revert that side of it and just focus on the spurious awakening prevention stuff.
Fixes #482