New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow tests to pass without XBR dependencies #1579
Comments
yeah, the XBR dependencies can be painful, this is because Ethereum is a complete new world, everything is moving quite fast, and is hashed out on the fly;) It's just the early phase of ground breaking new tech - unavoidable pain during birth. rgd the issue: if someone comes up with a PR, sure! otherwise, just package without testing. |
one more hint rgd this XBR stuff: this is very new and experimental, but I'd expect it to become more important to Autobahn/WAMP users looking forward (it is not relevant for users of only the WebSocket stuff in Autobahn). eg it will allow to create WAMP realms shared between and hosted by multiple parties, and also to define and share WAMP API definitions ... |
Sometimes Arch Linux comes with newer dependencies or newer Python versions. Usually we enable tests to ensure compatibility. I will try to make a PR to skip tests.
Sounds interesting. The program I use (buildbot) does use WAMP. I will check XBR dependencies again at that time. Hopefully packages for XBR dependencies will be easier to maintain then :) |
working on it;) BB: +1 !! great project and people=) To give a bit more preview, one thing that BB might indeed be interested in: formalizing their WAMP based BB APIs by writing schemas (in FlatBuffers IDL), and then profit by docs / code generation, payload validation and (future) run-time interface reflection the last screenshot is my ugly demo of auto rendering docs from WAMP APIs ... works via Jinja2 templates and a LMDB schema store, and with Crossbar.io as router (https://github.com/crossbario/crossbar-examples/blob/c67e99777ab7eb12cacab34957a245ce01d28cef/payload-validation/static/.crossbar/config.json#L105) anyways, it is under development, not yet ready for prime time;) |
Cool! While I'm more a buildbot user than a dev, I believe buildbot devs will be interested in those nice improvements as well :) |
* Allow tests to pass without XBR dependencies - fixes #1579 * Address review comments * Fix test skipping notes
For version 22.5.1, tests fail if XBR dependencies are not installed:
Test failures
Could you consider allowing tests to pass without XBR dependencies? For example, some other tests under autobahn/xbr first do
from autobahn.xbr import HAS_XBR
, and then import other XBR dependencies only when HAS_XBR is True. Relevant tests are also skipped if HAS_XBR is False.I'm one of maintainers of official Arch Linux package python-autobahn. Maintaining XBR dependencies is a burden, so no related dependencies are picked into official repositories yet. I didn't use AUTOBAHN_STRIP_XBR introduced in #1371, so that users can still use autobahn.xbr if they installed necessary dependencies from unofficial packages.
The text was updated successfully, but these errors were encountered: