Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not try to reconnect if unix socket doesn't exist #1534

Open
om26er opened this issue Mar 25, 2022 · 2 comments
Open

Should not try to reconnect if unix socket doesn't exist #1534

om26er opened this issue Mar 25, 2022 · 2 comments

Comments

@om26er
Copy link
Contributor

om26er commented Mar 25, 2022

If a new connection is established to the router using UDS and due to some reason the router is stopped, autobahn uses the same reconnect mechanism that it uses for TCP based transports.

IMO we could avoid doing the unneeded retry attempts if the UDS path doesn't exist. Having that feature would also mean that local clients can connect to the router instantly as soon as the UDS becomes available. (or at least on the next try if router workers take some time to fully start)

@om26er om26er changed the title unix socket: Should not try to reconnect if UDS doesn't exist Should not try to reconnect if unix socket doesn't exist Mar 25, 2022
@om26er
Copy link
Contributor Author

om26er commented Mar 25, 2022

So basically instead of an attempt to reconnect, we should do a os.path.exists instead.

@oberstet
Copy link
Contributor

yeah, I get it, makes sense to improve the behavior as you hint!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants