Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cryptosign authextra allow arbitrary keys #1411

Merged
merged 1 commit into from Aug 18, 2020
Merged

cryptosign authextra allow arbitrary keys #1411

merged 1 commit into from Aug 18, 2020

Conversation

om26er
Copy link
Contributor

@om26er om26er commented Aug 18, 2020 •
edited

Fixes #1412

meejah
meejah approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@meejah meejah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oberstet
Copy link
Contributor

yeah, should be good. merging. for background: I am generally following a conservative approach, that is, explicitly check and disallow anything not strictly required. but I can't see much potential for harm or maintenance headaches down the line in this case ..

@oberstet oberstet merged commit d75be09 into crossbario:master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meejah meejah meejah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

authextra in cryptosign auth should allow arbitrary values
3 participants
@om26er @oberstet @meejah