Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environmental variable that strips xbr. #1374

Merged
merged 1 commit into from Apr 25, 2020

Conversation

jameshilliard
Copy link
Contributor

This will create distributions and installations without xbr when the env variable AUTOBAHN_STRIP_XBR is set.

@oberstet oberstet merged commit 95ece3c into crossbario:master Apr 25, 2020
@oberstet
Copy link
Contributor

ok, cool! this looks like it addresses all concerns .. the added (amount of) lines: we can handle that .. not too much hassles/work.

so as you mentioned somewhere, yeah, xbr isn't yet broadly used .. should have little external effect. our own stuff: I don't expect much now .. it's non-intrusive .. let's see;)

thanks for your time and work in contributing!

@jameshilliard
Copy link
Contributor Author

Thanks, by the way it's probably still a good idea to split the contracts out into a separate repo in addition to this change, mostly just so that autobahn downloads are faster as autobahn is a dependency for many projects, that's more of an issue for non-buildroot usages of autobahn(docker images for example) however as buildroot cross compiles packages on a host system and installs to the target image.

Buildroot downloads a large amount of code during a build anyways so the size doesn't make a huge difference on the download size, it's the target installation size that's the big issue, buildroot tightly controls what actually ends up on the target image to keep things small.

@jameshilliard jameshilliard deleted the strip-xbr branch April 25, 2020 08:39
@oberstet
Copy link
Contributor

it's probably still a good idea to split the contracts out into a separate ..

.. package

#1375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants