Skip to content

Streamline websocket selection #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 18, 2019
Merged

Streamline websocket selection #479

merged 2 commits into from
Oct 18, 2019
+63 −89

Conversation

om26er
Copy link
Contributor

@om26er om26er commented Oct 17, 2019 •
edited
Loading

  • If the globals doesn't have WebSocket, its not a browser (Chrome, Firefox, Opera, Edge)
  • Remove special branching for Electron
  • Remove support for very old Firefox

@oberstet oberstet merged commit d478577 into crossbario:master Oct 18, 2019
@oberstet
Copy link
Contributor

yeah, look good! it turns around the detection (doesn't try to positively detect a non-browser env). hopefully it works;)

@om26er om26er mentioned this pull request Oct 18, 2019
Closed
@om26er om26er mentioned this pull request Dec 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@om26er @oberstet