v0.6.1 only works if debug mode is enabled

[jonahbeckford]

Continues #11.

I tried v0.6.1 and it now only works if I have debug mode enabled:

Syncing back files
/usr/bin/rsync -uzrtopg  runner@192.168.64.2:work/ /Users/runner/work
rsync: link_stat "/Users/runner/work/dkml-c-probe/dkml-c-probe/runner@192.168.64.2:work/." failed: No such file or directory (2)
rsync error: some files could not be transferred (code 23) at /AppleInternal/BuildRoot/Library/Caches/com.apple.xbs/Sources/rsync/rsync-54.120.1/rsync/main.c(996) [sender=2.6.9]
Terminating VM
/usr/bin/sudo kill -s TERM 1469

I think it is because with an empty syncVerboseFlag:

action/src/action/action.ts

Lines 225 to 227 in 52ad2be

	private get syncVerboseFlag(): string {
	return core.isDebug() ? '-v' : ''
	}

in

action/src/action/action.ts

Lines 235 to 242 in 52ad2be

	await exec.exec('rsync', [
	'-auzrtopg',
	this.syncVerboseFlag,
	'--exclude', '_actions/cross-platform-actions/action',
	...flatMap(excludePaths, p => ['--exclude', p]),
	`${this.workDirectory}/`,
	`runner@${ipAddress}:work`
	])

you would get the second argument (this.syncVerboseFlag) as an empty string.

rsync will see the empty string and try to sync that.

Originally posted by @jonahbeckford in #11 (comment)

[jacob-carlborg]

I would have hoped the empty string would be ignored but I guess that only works when executing the command through a shell, which is not happening here.

[jacob-carlborg]

Hmm, I think the CI pipeline for this project runs in debug mode, that's why it passed.

[jacob-carlborg]

Please try 0.6.2 now.

[jonahbeckford]

Works. Thx!